Ticket #32 (closed defect: fixed)

Opened 7 months ago

Last modified 6 months ago

Rewind on closed stream when uploading

Reported by: mgranger Assigned to: mgranger
Priority: major Milestone: ThingFish 0.3 - The "N-Robot" Release
Component: ThingFish Keywords: rewind closed stream filter upload thingfish
Cc: Depends on:

Description

When uploading a fairly large tarball recently, I encountered the following error:

[2008-02-28 11:06:00.315303 71958/110520] DEBUG {ThingFish::Request} -- 
    Parsed 1 bodies and 2 form_metadata ([:rating, :namespace])
[2008-02-28 11:06:00.315438 71958/110520] ERROR {ThingFish::Daemon} -- 
    IOError while running : closed stream
[2008-02-28 11:06:00.315509 71958/110520] DEBUG {ThingFish::Daemon} -- 
    Handlers were:
  
Backtrace:  (eval):3:in `rewind'
  ./lib/thingfish/request.rb:299:in `rewind_bodies'
  ./lib/thingfish/request.rb:298:in `each'
  ./lib/thingfish/request.rb:298:in `rewind_bodies'
  ./lib/thingfish/daemon.rb:299:in `filter_request'
  ./lib/thingfish/daemon.rb:288:in `each'
  ./lib/thingfish/daemon.rb:288:in `filter_request'
  ./lib/thingfish/daemon.rb:245:in `dispatch_to_handlers'
  ./lib/thingfish/daemon.rb:235:in `dispatch'
  ./lib/monkeypatches.rb:122:in `process_client'
  [...]/mongrel-1.1.3/lib/mongrel.rb:285:in `run'
  [...]/mongrel-1.1.3/lib/mongrel.rb:285:in `initialize'
  [...]/mongrel-1.1.3/lib/mongrel.rb:285:in `new'
  [...]/mongrel-1.1.3/lib/mongrel.rb:285:in `run'
  [...]/mongrel-1.1.3/lib/mongrel.rb:268:in `initialize'
  [...]/mongrel-1.1.3/lib/mongrel.rb:268:in `new'
  [...]/mongrel-1.1.3/lib/mongrel.rb:268:in `run'
  ./lib/thingfish/daemon.rb:139:in `run'
  bin/thingfishd:90:in `run'
  bin/thingfishd:31:in `main'
  bin/thingfishd:100

This happened in the look and feel branch, but I suspect it's related to our recent changes in the way entity bodies are treated between filters.

Change History

03/11/08 08:38:37 changed by mahlon

  • milestone changed from ThingFish 0.2 - The "Butterhand" Release to ThingFish 0.3 - The "N-Robot" Release.

03/11/08 08:39:22 changed by mahlon

Also, see ticket #33.

03/27/08 07:03:47 changed by mahlon

  • status changed from new to closed.
  • depends_on changed.
  • resolution set to fixed.

Fixed in r493 and r494.